netdev - Re: [PATCH 1/3] macvtap: rework object lifetime rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100218.141126.38076586.davem@davemloft.net>
Date:	Thu, 18 Feb 2010 14:11:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	sri@...ibm.com, kaber@...sh.net, eswierk@...stanetworks.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] macvtap: rework object lifetime rules

From: Arnd Bergmann <arnd@...db.de>
Date: Thu, 18 Feb 2010 16:45:36 +0100

> This reworks the change done by the previous patch
> in a more complete way.
> 
> The original macvtap code has a number of problems
> resulting from the use of RCU for protecting the
> access to struct macvtap_queue from open files.
> 
> This includes
> - need for GFP_ATOMIC allocations for skbs
> - potential deadlocks when copy_*_user sleeps
> - inability to work with vhost-net
> 
> Changing the lifetime of macvtap_queue to always
> depend on the open file solves all these. The
> RCU reference simply moves one step down to
> the reference on the macvlan_dev, which we
> only need for nonblocking operations.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html