netdev - Re: [PATCH net-next 14/15] drivers/net/typhoon.c: Use (pr|netdev)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1266463341.5719.96.camel@obelisk.thedillows.org>
Date:	Wed, 17 Feb 2010 22:22:21 -0500
From:	David Dillow <dave@...dillows.org>
To:	David Miller <davem@...emloft.net>
Cc:	joe@...ches.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 14/15] drivers/net/typhoon.c: Use
 (pr|netdev)_<level> macro helpers

On Wed, 2010-02-17 at 19:10 -0800, David Miller wrote:
> > From: David Dillow <dave@...dillows.org>
> > Date: Wed, 17 Feb 2010 21:30:21 -0500
> > I liked it because it consistent with eth device naming when it could
> > be, and gave them useful info to go on when it failed during
> > initialization.
> 
> How can printing a PCI device name string be consistent with eth
> device naming?

I meant that once it had been probed and initialized, it used the eth
name, consistent with other network drivers. Prior to that, it gave as
much info as it could to identify the failing device.

> I already tossed his patch from my tree.

Ok, I'll continue to work with Joe to get this acceptable to all of us.
I really need to focus on paying work tonight, so this will have to wait
until the weekend, but we'll have a replacement to you by Monday.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html