netdev - Re: [PATCH 1/2] net: Fix sysctl restarts...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100219.152954.39315470.davem@davemloft.net>
Date:	Fri, 19 Feb 2010 15:29:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: Fix sysctl restarts...

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Fri, 19 Feb 2010 15:22:59 -0800

> 
> Yuck.  It turns out that when we restart sysctls we were restarting
> with the values already changed.  Which unfortunately meant that
> the second time through we thought there was no change and skipped
> all kinds of work, despite the fact that there was indeed a change.
> 
> I have fixed this the simplest way possible by restoring the changed
> values when we restart the sysctl write.
> 
> One of my coworkers spotted this bug when after disabling forwarding
> on an interface pings were still forwarded.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

What commit added this bug?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html