netdev - Re: [RFC 1/2] sctp: convert hash list to RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1266568869.3136.0.camel@edumazet-laptop>
Date:	Fri, 19 Feb 2010 09:41:09 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Vlad Yasevich <vladislav.yasevich@...com>,
	Sridhar Samudrala <sri@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: [RFC 1/2] sctp: convert hash list to RCU

Le vendredi 19 février 2010 à 09:13 +0100, Eric Dumazet a écrit :
> Le jeudi 18 février 2010 à 21:55 -0800, Stephen Hemminger a écrit :
> > pièce jointe document texte brut (sctp-rcu.patch)
> > This patch converts existing SCTP hash list to using RCU
> > rather than reader/writer lock. Also, get rid of no longer used
> > locking wrappers.
> > 
> > In future, the SCTP hash locking should be broken out from the
> > hash structure because of the wasted space for the hash locks
> > and associated holes. A single lock per hashlist is sufficient
> > now that RCU is used.
> > 
> > Compile tested only. I can't think of an SCTP stress application.
> > 
> > P.s: Some janitor ought to go through and remove the locking
> > macros here.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> > 
> 
> Stephen, I read full patch and cannot see how you respect the rcu grace
> period at dismantle phase. I am not familiar with SCTP, maybe its
> already done ? (before the patch)
> 

OOps sorry, I finaly saw the light, please ignore this comment.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html