netdev - Re: [PATCH 2/5] netlink: store MSG_CMSG_COMPAT flag in netlink_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Feb 2010 14:34:15 +0100
From:	Florian Westphal <fw@...len.de>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/5] netlink: store MSG_CMSG_COMPAT flag in
 netlink_skb_parms

Johannes Berg <johannes@...solutions.net> wrote:
> On Fri, 2010-02-19 at 13:41 +0100, Florian Westphal wrote:
> > From: Florian Westphal <fw@...len.de>
> > 
> > This allows the netlink processing context to determine if the data
> > needs any 32 bit fixups.
> > 
> > Cc: Johannes Berg <johannes@...solutions.net>
> > Signed-off-by: Florian Westphal <fw@...len.de>
> > ---
> >  changes since v1: change msg_compat to bool.
> > 
> >  include/linux/netlink.h  |    1 +
> >  net/netlink/af_netlink.c |    3 +++
> >  2 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/netlink.h b/include/linux/netlink.h
> > index fde27c0..c094694 100644
> > --- a/include/linux/netlink.h
> > +++ b/include/linux/netlink.h
> > @@ -164,6 +164,7 @@ struct netlink_skb_parms {
> >  	__u32			loginuid;	/* Login (audit) uid */
> >  	__u32			sessionid;	/* Session id (audit) */
> >  	__u32			sid;		/* SELinux security id */
> > +	bool			msg_compat;	/* Message needs 32bit fixups */
> >  };
> >  
> >  #define NETLINK_CB(skb)		(*(struct netlink_skb_parms*)&((skb)->cb))
> > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> > index 4910031..5ff97cf 100644
> > --- a/net/netlink/af_netlink.c
> > +++ b/net/netlink/af_netlink.c
> > @@ -1328,6 +1328,9 @@ static int netlink_sendmsg(struct kiocb *kiocb,
> > struct socket *sock,
> >  	NETLINK_CB(skb).dst_group = dst_group;
> >  	NETLINK_CB(skb).loginuid = audit_get_loginuid(current);
> >  	NETLINK_CB(skb).sessionid = audit_get_sessionid(current);
> > +#ifdef CONFIG_COMPAT_NETLINK_MESSAGES
> > +	NETLINK_CB(skb).msg_compat = !!(msg->msg_flags & MSG_CMSG_COMPAT);
> > +#endif
> 
> Can't really decide ... does that ifdef make sense? Or should the
> variable be ifdef'ed as well?

The define is there because the assignment is only relevant for
COMPAT_NETLINK_MESSAGES=y.

I did not add the define to netlink.h because I don't see any advantage.

But I do not mind changing this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html