netdev - Re: [RFC 4/4] bond: add new multiqueue hash policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 19 Feb 2010 20:54:17 +0300
From:	"\"Oleg A. Arkhangelsky\"" <sysoleg@...dex.ru>
To:	netdev@...r.kernel.org
Subject: Re: [RFC 4/4] bond: add new multiqueue hash policy

Hello Stephen,

> This hash policy just uses existing transmit hash used for
> mulitiqueue.

> Signed-off-by: Stephen Hemminger

> +/*
> + * Hash for the output device based on multiqueue transmit hash policy
> + */
> +static u16 bond_xmit_hash_policy_mq(const struct sk_buff *skb)
> +{
> +	return skb_tx_hash(skb->dev, skb);
> +}

I think that it would be better to use something like this here:

return skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : 0;

Bonding is currently non-multiqueue aware and skb_tx_hash() will return zero
everytime.

-- 
wbr, Oleg.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html