netdev - Re: [PATCH 2.6.34] r8169: enable 64-bit DMA by default for PCI Express devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100219.131718.115496278.davem@davemloft.net>
Date:	Fri, 19 Feb 2010 13:17:18 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hancockrwd@...il.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	romieu@...zoreil.com
Subject: Re: [PATCH 2.6.34] r8169: enable 64-bit DMA by default for PCI
 Express devices

From: Robert Hancock <hancockrwd@...il.com>
Date: Wed, 17 Feb 2010 21:06:41 -0600

> Currently use of 64-bit DMA is disabled in r8169 unless the user passes the
> use_dac module option. This is reasonable for conventional PCI devices where
> broken chipsets may not handle dual-address-cycle transfers properly for
> 32-bit slots and so this may not be safe. However, PCI Express should not have
> this problem and not using 64-bit DMA results in DMA transfers needlessly using
> the IOMMU or SWIOTLB. Set the use_dac module parameter to a new default value of
> -1 which results in 64-bit DMA being enabled by default for PCI Express devices
> only.
> 
> Signed-off-by: Robert Hancock <hancockrwd@...il.com>

This patch is fine, but it doesn't apply cleanly to net-next-2.6

Please fix this up and resubmit, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html