netdev - Re: [PATCH] greth: some driver cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100219.131819.27458744.davem@davemloft.net>
Date:	Fri, 19 Feb 2010 13:18:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	kirjanov@...il.com, kristoffer@...sler.com, netdev@...r.kernel.org
Subject: Re: [PATCH] greth: some driver cleanups

From: Jiri Pirko <jpirko@...hat.com>
Date: Fri, 19 Feb 2010 16:25:02 +0100

> Fri, Feb 19, 2010 at 04:00:52PM CET, kirjanov@...il.com wrote:
>>On Fri, Feb 19, 2010 at 13:51 +0100, Jiri Pirko wrote:
>>> 
>>> <snip>
>>> >>@@ -1031,7 +1029,7 @@ static void greth_set_multicast_list(struct net_device *dev)
>>> >> 			return;
>>> >> 		}
>>> >> 
>>> >>-		if (dev->mc_count == 0) {
>>> >>+		if (!netdev_mc_count(dev)) {
>>> also please use netdev_mc_empty() here.
>>Some driver cleanups:
>>* convert to use phy_find_first/phy_direct_connect
>>* convert to use netdev_mc_* helpers
>>* fixed missing validate_addr hook
>>* removed netdev_priv castings
>>
>>Signed-off-by: Denis Kirjanov <kirjanov@...il.com>
 ...
> Looks good.
> 
> Reviewed-by: Jiri Pirko <jpirko@...hat.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html