netdev - Re: [PATCH 1/2] net: Fix sysctl restarts...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100219.160259.266645466.davem@davemloft.net>
Date:	Fri, 19 Feb 2010 16:02:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: Fix sysctl restarts...

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Fri, 19 Feb 2010 15:58:53 -0800

> David Miller <davem@...emloft.net> writes:
> 
> 2> From: ebiederm@...ssion.com (Eric W. Biederman)
>> Date: Fri, 19 Feb 2010 15:35:27 -0800
>>
>>> When we I fixed the deadlock that can happen if you write to forwarding
>>> while removing the device.  The deadlock was fixed, the restart worked
>>> but I somehow missed the fact that proc_dointvec modifies state and so
>>> defeated the change detection.  *embarrassing*
>>
>> Ok, I'll have to push these around to Linus and a couple -stable
>> releases.
> 
> The second patch fixes an issue which isn't quite as old.
> 
> I caught it when I was looking for other rtnl_lock issues that
> I may have missed.  Thankfully the worst sysfs does is re-read
> the string from userspace on a restart so none of the sysfs
> rtnl_trylock cases have a nasty deadlock associated.
> 
> Eric
> 
> 
> commit a160ee69c6a4622ed30c377a978554015e9931cb
> Author: Johannes Berg <johannes@...solutions.net>
> Date:   Mon Oct 5 02:22:23 2009 -0700

So the second patch needs to go to less -stable releases than the
other one.  Thanks for the info.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html