netdev - Re: [PATCH 3/3] af_key: locking change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100220.125145.173499637.davem@davemloft.net>
Date:	Sat, 20 Feb 2010 12:51:45 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	eric.dumazet@...il.com, viro@...iv.linux.org.uk,
	akpm@...ux-foundation.org, rusty@...tcorp.com.au,
	oberpar@...ux.vnet.ibm.com, mszeredi@...e.cz,
	paulmck@...ux.vnet.ibm.com, jpirko@...hat.com, jolsa@...hat.com,
	mingo@...e.hu, adobriyan@...il.com, hadi@...erus.ca,
	nhorman@...driver.com, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] af_key: locking change

From: Stephen Hemminger <shemminger@...tta.com>
Date: Fri, 19 Feb 2010 21:53:14 -0800

> On Sat, 20 Feb 2010 05:07:30 +0100
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
>> Le vendredi 19 février 2010 à 13:59 -0800, Stephen Hemminger a écrit :
>> > pièce jointe document texte brut (pfkey-rcu.patch)
>> > Get rid of custom locking that was using wait queue, lock, and atomic
>> > to basically build a queued mutex.  Use RCU for read side.
>> > 
>> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>> 
>> Excellent
>> 
>> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
>> 
>> I dont know why you used synchronize_sched() instead of
>> synchronize_rcu().
> 
> I'll go back to synchronize_rcu.

Please also add some comments for patch #1 as requested by
Al Viro.

When you post the new series with these changes I'll apply
it to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html