[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1266752533.3428.28.camel@Nokia-N900-42-11>
Date: Sun, 21 Feb 2010 13:42:13 +0200
From: "Octavian Purdila" <opurdila@...acom.com>
To: "Cong Wang" <amwang@...hat.com>
Cc: "David Miller" <davem@...emloft.net>,
"Linux Kernel Network Developers" <netdev@...r.kernel.org>,
"Linux Kernel Developers" <linux-kernel@...r.kernel.org>,
"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [net-next PATCH v5 2/3] sysctl: add proc_do_large_bitmap
>
> My test shows it still accepts spaces, e.g.
>
> echo '50000 50003 50005' > ip_local_reserved_ports
>
> works same as
>
> echo '50000,50003,50005' > ip_local_reserved_ports
>
> Is this expected? We will only accept commas, right?
>
Thanks for testing, I didn't saw that comming! I wanted to allow whitespaces in between the commas but it looks like I got overzealous. I can easily fix that.
But I think its worth to keep the whitespaces in beetween, e.g. allow
$ echo '1, 2 ,3 ' > ip_local_reserved_ports.
>
> Also, if I write an invalid value, it does reject this, but the previous
> value in that file is cleared, shouldn't we keep the previous one?
>
>
The only way I see to fix this is to return EINVAL if we detect a write with offset.
IMO we should do that for the other proc write routines as well, as otherwise ther result is confusing, e.g.
write("1 2"); write(" 3");
will set first value in the vector to 1, than second value to 2 then *first* value to 3.
I am all for it, but again, this changes userspace ABI.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists