netdev - Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100221.223932.39195123.davem@davemloft.net>
Date:	Sun, 21 Feb 2010 22:39:32 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	rmody@...cade.com
Cc:	netdev@...r.kernel.org, adapter_linux_open_src_team@...cade.com
Subject: Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver


This driver still needs a lot of work.

The number of headers files is rediculious and I see pieces of
information duplicated up to 4 or 5 times (!?!??!)

First, reduce the header files to say two or three.

Next, remove all of the duplicated information.  You have at least two
copies of the PCI device ID in these header files.  There are three or
four definitions of the same statistics data structures.

It's pure bloat, you have to consolidate the content and the number of
header files holding this information.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html