netdev - Re: [PATCH 3/4] gigaset: reduce syslog clutter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B83CFBC.5030406@imap.cc>
Date:	Tue, 23 Feb 2010 13:53:16 +0100
From:	Tilman Schmidt <tilman@...p.cc>
To:	Joe Perches <joe@...ches.com>
CC:	Karsten Keil <isdn@...ux-pingi.de>,
	David Miller <davem@...emloft.net>,
	Hansjoerg Lipp <hjlipp@....de>,
	Karsten Keil <keil@...systems.de>,
	isdn4linux@...tserv.isdn4linux.de,
	i4ldeveloper@...tserv.isdn4linux.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] gigaset: reduce syslog clutter

Joe Perches schrieb:
> Perhaps it'd be useful to add a ethtool/netif_msg interface
> and classify the messages as appropriate.

Interesting idea. On first glance, however, I don't see how to map the
Gigaset driver's diverse debugging categories (like USB communication
vs. V.25ter communication vs. ISDN subsystem communication) to the
NETIF_MSG_ flags in a useful way.

What's more, ethtool only seems to allow the setting of a numerical
message "level" enabling all debug flags "below" that level. It cannot
enable, for example, NETIF_MSG_TX_ERR without NETIF_MSG_PROBE. The
Gigaset driver OTOH follows the concept of individually selectable areas
of interest. In fact, I make frequent use of that ability when I help a
user with troubleshooting. For example, a typical first setting for a
user who cannot make an ISDN connection would be the value 0x102020
mentioned in the README.

OTOH, the ability to control the "non-debug" verbosity of the Gigaset
driver (ie. the messages not controlled by the "debug" parameter) with
ethtool/netif_msg might be appreciated. Perhaps that's what you had in mind?

Thanks,
Tilman
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html