netdev - Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1266940741.2109.7.camel@achroite.uk.solarflarecom.com>
Date:	Tue, 23 Feb 2010 15:59:01 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	"\"Oleg A. Arkhangelsky\"" <sysoleg@...dex.ru>
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and
 VLAN devices

On Tue, 2010-02-23 at 18:17 +0300, "Oleg A. Arkhangelsky" wrote:
> 
> Must be applied with "[net-next-2.6 PATCH] Multiqueue support for bonding devices"
> 
> Forwarded packet goes more that once throught dev_queue_xmit() when
> using bonding or 802.1q VLAN devices, so we've lost rx-tx queue mapping
> index for real devices.
[...]

The queue mapping will normally be the same, only no longer biased by 1.
So I think a better solution would be to maintain that bias on TX as
well, or to remove the bias and reserve -1 for unknown RX queue.

We already have hardware that can do RSS across up to 128 RX queues, so
an 8-bit limit is uncomfortably close.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html