netdev - Re: [PATCH net-next 0/7] cxgb4 patches V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100223.144054.261850790.davem@davemloft.net>
Date:	Tue, 23 Feb 2010 14:40:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dm@...lsio.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/7] cxgb4 patches V2

From: Dimitris Michailidis <dm@...lsio.com>
Date: Tue, 23 Feb 2010 11:07:29 -0800

> Can you please clarify what exactly you want me to change about the
> macros?  I looked at a few other drivers in the tree and I saw shift
> macros with _SHIFT or _SH suffixes, masks tend to have _MASK or _MSK
> suffixes, etc.  Are you asking me basically to change our S_, V_, etc
> prefixes to _SHIFT, etc suffixes or are we talking about some other
> kind of change?  Please bear with me, I am trying to understand what
> you're asking for exactly.

Yes.  Don't put things at the beginning, start with the register
name then add things at the end for shifts, masks, etc.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html