netdev - Re: [PATCH v2 5/7] pci: Add helper to search for VPD keywords

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1267217351.2098.19.camel@achroite.uk.solarflarecom.com>
Date:	Fri, 26 Feb 2010 20:49:11 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Matt Carlson <mcarlson@...adcom.com>
Cc:	jbarnes@...tuousgeek.org, linux-pci@...r.kernel.org,
	netdev@...r.kernel.org, andy@...yhouse.net,
	Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH v2 5/7] pci: Add helper to search for VPD keywords

On Fri, 2010-02-26 at 12:40 -0800, Matt Carlson wrote:
> This patch adds the pci_vpd_find_info_keyword() helper function to
> find information field keywords within read-only and read-write large
> resource data type sections.
[...]
> +/**
> + * pci_vpd_find_info_keyword - Locates an information field keyword in the VPD
> + * @buf: Pointer to buffered vpd data
> + * @off: The offset into the buffer at which to begin the search
> + * @len: The length of the buffer area, relative to off, in which to search
> + * @kw: The keyword to search for
> + *
> + * Returns the index where the information field keyword was found or
> + * -ENOENT otherwise.
> + */
> +int pci_vpd_find_info_keyword(u8 *buf, unsigned int off,
> +			      unsigned int len, char *kw);
[...]

The kw pointer should be const-qualified.  The buf pointers could also
be const-qualified though this is less important.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html