netdev - Re: [PATCH net-next 3/6] cnic: Fix panic in cnic_iscsi_nl_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C27F8246C663564A84BB7AB34397724218312F8FD0@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Thu, 25 Feb 2010 23:01:59 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"'Simon Horman'" <horms@...ge.net.au>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 3/6] cnic: Fix panic in
 cnic_iscsi_nl_msg_recv() when device is down.

Simon Horman wrote:

> On Wed, Feb 24, 2010 at 04:42:06PM -0800, Michael Chan wrote:
> > Some data structures are freed when the device is down and it will
> > crash if an ISCSI netlink message is received.  Add RCU protection
> > to prevent this.  In the shutdown path, ulp_ops[CNIC_ULP_L4] is
> > assigned NULL and rcu_synchronized before freeing the data
> > structures.
>
> Is rcu_assign_pointer() unnecessary in cnic_cm_open()?
> It doesn't seem to be followed by rcu_synchronized() and the pointer
> doesn't seem to be accessible anywhere else at that time.

We assign a valid pointer in cnic_cm_open() so that it can be used
during run-time (in service_kcqes() for example).  During shutdown in
cnic_stop_hw(), we assign NULL followed by rcu_synchronize().

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html