netdev - Re: [PATCH] isa-skelton: Remove a wrong netif_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100226.015138.00843007.davem@davemloft.net>
Date:	Fri, 26 Feb 2010 01:51:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	anemo@....ocn.ne.jp
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] isa-skelton: Remove a wrong netif_wake_queue() call

From: Atsushi Nemoto <anemo@....ocn.ne.jp>
Date: Thu, 25 Feb 2010 01:00:17 +0900

> The netif_wake_queue() is called correctly (i.e. only on !txfull
> condition) from net_tx().  So Unconditional call to the
> netif_wake_queue() here is wrong.  This might cause calling of
> start_xmit routine on txfull state and trigger tx-ring overflow.
> 
> This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>

Applied.

Please reference commits by also making mention of the commit
log message header line.  This way when a patch is backported
into another tree, people can still find it even if the
SHA1 ID is different.  For exmaple, I fixed the above to
read:

    This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687
    ("tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON").

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html