netdev - Re: [net-next-2.6 PATCH 2/3] ixgbe: do not stop tx queues in ixgbe_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100226.021044.47249344.davem@davemloft.net>
Date:	Fri, 26 Feb 2010 02:10:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	john.r.fastabend@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-next-2.6 PATCH 2/3] ixgbe: do not stop tx queues in
 ixgbe_set_tso

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 26 Feb 2010 01:14:58 -0800

> From: John Fastabend <john.r.fastabend@...el.com>
> 
> Disabling TSO can cause the dev_watchdog timer to be triggered because
> when TSO is disabled netif_tx_stop_all_queues is called.  If the watchdog
> timer fires while the queues are stopped and traffic has not recently been
> sent on a paticular queue this is falsly identified as a hang and
> ndo_tx_timeout() is called.  This is ocossionally seen during testing.
> 
> This removes the netif_tx_stop_all_queues() it is not needed.  The scheduler
> submits skb's with dev_hard_start_xmit(), this checks if netif_needs_gso and
> if so it calls dev_gso_segment.  Disabling TSO will cause dev_hard_start_xmit()
> to do the gso processing.   However ixgbe does not use the features flags to
> determine if it needs to use tso or not instead it uses skb->gso_size so
> ixgbe will process these frames correctly regardless of the netdev features
> flag.
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html