netdev - Re: [PATCHv2] can: ti hecc module : add platform specific initialization callback.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100226.043215.79129135.davem@davemloft.net>
Date:	Fri, 26 Feb 2010 04:32:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mkl@...gutronix.de
Cc:	srk@...com, socketcan-core@...ts.berlios.de, netdev@...r.kernel.org
Subject: Re: [PATCHv2] can: ti hecc module : add platform specific
 initialization callback.

From: Marc Kleine-Budde <mkl@...gutronix.de>
Date: Thu, 25 Feb 2010 19:00:24 +0100

> Sriramakrishnan wrote:
>> CAN module on AM3517 requires programming of IO expander as part
>> of init sequence - to enable CAN PHY. Added platform specific
>> callback to handle phy control(switch on /off).
>> 
>> Signed-off-by: Sriramakrishnan <srk@...com>
> 
> looks good, just minor nitpicking inline

Please address the feedback and resubmit this patch.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html