netdev - Re: [net-next-2.6 PATCH] ixgbe: move TC_PRIO_CONTROL check into ixgbe_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100227.032832.54223147.davem@davemloft.net>
Date:	Sat, 27 Feb 2010 03:28:32 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	john.r.fastabend@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-next-2.6 PATCH] ixgbe: move TC_PRIO_CONTROL check into
 ixgbe_select_queue()

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 26 Feb 2010 16:21:36 -0800

> From: John Fastabend <john.r.fastabend@...el.com>
> 
> Move TC_PRIO_CONTROL check and queue remapping into
> ixgbe_select_queue().  Remapping queues after the qdisc
> can result in the wrong qdisc queue being stopped with
> netif_stop_subqueue().  Even if this is resolved and the
> correct queue is stopped it can result in a queue being
> blocked by TC_PRIO_CONTROL frames uneccesarily.  Moving
> this into the select_queue routine maintains alignment
> between tx_rings and qdisc queues.
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html