netdev - Re: [PATCH net-next-2.6 1/2] mq: support for bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1267288154.9082.23.camel@edumazet-laptop>
Date:	Sat, 27 Feb 2010 17:29:14 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"\"Oleg A. Arkhangelsky\"" <sysoleg@...dex.ru>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 1/2] mq: support for bonding

Le samedi 27 février 2010 à 16:27 +0300, "Oleg A. Arkhangelsky" a
écrit :
> 
> Make bonding driver multiqueue aware.
> 

I wish it could be true :)

> Signed-off-by: Oleg A. Arkhangelsky <sysoleg@...dex.ru> 
> 
> ---
> 
>  drivers/net/bonding/bond_main.c |    5 +++--
>  drivers/net/bonding/bonding.h   |    1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 430c022..ea4ff33 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -4928,8 +4928,9 @@ int bond_create(struct net *net, const char *name)
>  
>  	rtnl_lock();
>  
> -	bond_dev = alloc_netdev(sizeof(struct bonding), name ? name : "",
> -				bond_setup);
> +	bond_dev = alloc_netdev_mq(sizeof(struct bonding), name ? name : "",
> +				bond_setup,
> +				min_t(u32, BOND_MAX_TX_QUEUES, num_online_cpus()));
>  	if (!bond_dev) {
>  		pr_err("%s: eek! can't alloc netdev!\n", name);
>  		res = -ENOMEM;
> diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
> index 257a7a4..4a6cfb4 100644
> --- a/drivers/net/bonding/bonding.h
> +++ b/drivers/net/bonding/bonding.h
> @@ -29,6 +29,7 @@
>  #define DRV_DESCRIPTION	"Ethernet Channel Bonding Driver"
>  
>  #define BOND_MAX_ARP_TARGETS	16
> +#define BOND_MAX_TX_QUEUES	8 
>  
>  #define IS_UP(dev)					   \
>  	      ((((dev)->flags & IFF_UP) == IFF_UP)	&& \
> 
> ---
> 

Hi Oleg

1) Could you explain why this arbitrary value (8) was chosen ?

My dev machine has 16 cpus, and my network card has 16 queues per NIC

2) This multi queue support is not a real one, since bond driver is
currently using a per device central lock (bond->lock and
bond->curr_slave_lock).
Every xmit has to get this lock(s) and performance is not optimal.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html