netdev - Re: [net-next-2.6 PATCH v2] net: consolidate netif_needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100228.002942.28812162.davem@davemloft.net>
Date:	Sun, 28 Feb 2010 00:29:42 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, john.r.fastabend@...el.com
Subject: Re: [net-next-2.6 PATCH v2] net: consolidate netif_needs_gso()
 checks

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sun, 28 Feb 2010 08:29:53 +0800

> On Sat, Feb 27, 2010 at 08:17:09AM -0800, David Miller wrote:
>> From: Herbert Xu <herbert@...dor.apana.org.au>
>> Date: Sat, 27 Feb 2010 23:52:45 +0800
>> 
>> > I just did a grep on net/sched and couldn't see anything obvious
>> > that uses transport_header.
>> 
>> I think skb_checksum_help() would be such a use and I
>> see a reference in net/sched/sch_netem.c
> 
> AFAICS skb_checksum_help uses csum_start and not transport_header.
> Has this changed recently?
> 
> Once upon a time some drivers used transport_header instead of
> csum_start, but even those seem to be gone mostly so one day we
> could remove this setting completely.

Ok, then this clears up all of my concerns.  Thanks Herbert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html