netdev - Re: Adding inode field to /proc/net/netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1267348431.9082.66.camel@edumazet-laptop>
Date:	Sun, 28 Feb 2010 10:13:51 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	yamato@...hat.com, netdev@...r.kernel.org
Subject: Re: Adding inode field to /proc/net/netlink

Le dimanche 28 février 2010 à 01:00 -0800, David Miller a écrit :
> From: Masatake YAMATO <yamato@...hat.com>
> Date: Sun, 28 Feb 2010 14:45:37 +0900 (JST)
> 
> > The Inode field in /proc/net/{tcp,udp,packet,raw,...} is useful to know the types of 
> > file descriptors associated to a process. Actually lsof utility uses the field.
> > Unfortunately, unlike /proc/net/{tcp,udp,packet,raw,...}, /proc/net/netlink doesn't have the field.
> > This patch adds the field to /proc/net/netlink.
> > 
> > Signed-off-by: Masatake YAMATO <yamato@...hat.com>
> 
> Unfortunately we cannot add new fields without breaking the parsing
> done by existing applications.

Hmm we already did such expansion last year with commit 38938bfe when
Pablo Neira Ayuso added the Drops column

Extract of its Changelog :

 This patch also includes the use of sk_drop to account the number of
 netlink messages drop due to overrun. This value is shown in
 /proc/net/netlink.

So yes, some applications might break but they probably already broke
one year ago and their maintainers should know that adding new fields at
the end of lines is expected ?

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html