netdev - Re: [PATCH] ethtool: do not set some flags, if others failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100228.014047.212690802.davem@davemloft.net>
Date:	Sun, 28 Feb 2010 01:40:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: do not set some flags, if others failed

From: Jeff Garzik <jeff@...zik.org>
Date: Sat, 27 Feb 2010 02:43:38 -0500

> 
> NETIF_F_NTUPLE flag setting introduced a bug:  non-ntuple flags
> like LRO may be successfully set, before ioctl(2) returns failure
> to userspace.
> 
> The set-flags operation should be all-or-none, rather than leaving
> things in an inconsistent state prior to reporting failure to
> userspace.
> 
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>

Applied, thanks Jeff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html