netdev - Re: [PATCH net-next-2.6 2/2] mq: preserve queue mapping with bonding and VLAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100228.184531.13756529.davem@davemloft.net>
Date:	Sun, 28 Feb 2010 18:45:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sysoleg@...dex.ru
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 2/2] mq: preserve queue mapping with
 bonding and VLAN devices

From: "\"Oleg A. Arkhangelsky\"" <sysoleg@...dex.ru>
Date: Sun, 28 Feb 2010 14:35:14 +0300

>>  In file included from include/linux/netfilter.h:6,
>>                   from include/net/netns/x_tables.h:5,
>>                   from include/net/net_namespace.h:18,
>>                   from include/linux/init_task.h:13,
>>                   from arch/sparc/kernel/init_task.c:5:
>>  include/linux/skbuff.h: In function ‘skb_get_queue_mapping’:
>>  include/linux/skbuff.h:2022: error: implicit declaration of function ‘skb_rx_queue_recorded’
> 
> Silly me. :( Corrected.

You're not testing your damn changes at all.  You're not build testing it,
and you're therefore certainly not run time testing it:

drivers/net/igb/igb_main.c: In function ‘igb_clean_rx_irq_adv’:
drivers/net/igb/igb_main.c:5290: error: implicit declaration of function ‘skb_record_rx_queue’
make[3]: *** [drivers/net/igb/igb_main.o] Error 1
make[2]: *** [drivers/net/igb] Error 2
make[1]: *** [drivers/net] Error 2

And this makes me furious.  You got one of the calls in this file, but
not the other one, proving you didn't build test this part of your
patch at all.

And you did this not once, but _TWICE_.  You pushed a new version of
this patch back at me so quickly that there is zero chance that you
took any time to double check things.

How in the world can I possibly trust you and the quality of your work?

I think we can wait on your patches until the next merge window.

Sorry.