netdev - Re: [PATCH 0/7] cxgb4: driver submission V4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 28 Feb 2010 18:59:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dm@...lsio.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/7] cxgb4: driver submission V4

From: David Miller <davem@...emloft.net>
Date: Sun, 28 Feb 2010 18:30:00 -0800 (PST)

> From: Dimitris Michailidis <dm@...lsio.com>
> Date: Sun, 28 Feb 2010 08:09:38 -0800
> 
>> 
>> This is V4 of the cxgb4 patches, which is V3 with need_skb_unmap removed.
> 
> Applied.

Nevermind, reverted.

You're not build testing your changes either:

drivers/net/cxgb4/cxgb4_main.c: In function 'cxgb_netpoll':
drivers/net/cxgb4/cxgb4_main.c:3470: warning: pointer type mismatch in conditional expression
drivers/net/cxgb4/cxgb4_main.c:3470: warning: passing argument 1 of 't4_intr_handler(adap)' makes integer from pointer without a cast
drivers/net/cxgb4/cxgb4_main.c:3470: note: expected 'int' but argument is of type 'void *'
drivers/net/cxgb4/cxgb4_main.c:3470: error: too few arguments to function 't4_intr_handler(adap)'
make[3]: *** [drivers/net/cxgb4/cxgb4_main.o] Error 1
make[3]: *** Waiting for unfinished jobs....

You know, I really can't believe people not only bomb me with all of
this last minute networking crap, but on top of it they are also doing
so with such poorly tested changes.

Stuff that doesn't even friggin' build!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html