lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1267497242.23196.62.camel@debian> Date: Tue, 02 Mar 2010 10:34:02 +0800 From: Zhu Yi <yi.zhu@...el.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, David Miller <davem@...emloft.net> Subject: Re: [PATCH V2] net: add accounting for socket backlog On Mon, 2010-03-01 at 19:43 +0800, Eric Dumazet wrote: > Thinking again about this, doing this zero initialization at the very > end of __release_sock() solves the problem of potential infinite loop > in > __release_sock(). Since producer will hit the backlog limit. > > Thanks > > diff --git a/net/core/sock.c b/net/core/sock.c > index 305cba4..544cf4a 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -1542,6 +1542,11 @@ static void __release_sock(struct sock *sk) > > bh_lock_sock(sk); > } while ((skb = sk->sk_backlog.head) != NULL); > + /* > + * Doing this zeroing at the end of this function guarantee we > can not > + * loop forever while a wild producer attempts to flood us > + */ > + sk->sk_backlog.len = 0; > } Very good point. I'll add your sob in my next patch. Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists