netdev - Re: [PATCH] be2net: fix tx completion polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100302.035649.53340739.davem@davemloft.net>
Date:	Tue, 02 Mar 2010 03:56:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sathyap@...verengines.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] be2net: fix tx completion polling

From: Sathya Perla <sathyap@...verengines.com>
Date: Tue, 2 Mar 2010 12:06:15 +0530

> On 26/02/10 04:19 -0800, David Miller wrote:
>> From: Sathya Perla <sathyap@...verengines.com>
>> Date: Thu, 25 Feb 2010 17:25:16 +0530
>> 
>> > In tx/mcc polling, napi_complete() is being incorrectly called
>> > before reaping tx completions. This can cause tx compl processing
>> > to be scheduled on another cpu concurrently which can result in a panic.
>> > This if fixed by calling napi complete() after tx/mcc compl processing
>> > but before re-enabling interrupts (via a cq notify).
>> > 
>> > Pls apply to net-2.6.
>> 
>> net-2.6 is closed, 2.6.33 has been released.
>> 
>> > Signed-off-by: Sathya Perla <sathyap@...verengines.com>
>> 
>> This patch does not apply to net-next-2.6
> 
> I've re-done the patch for net-next-2.6: Pls apply; thanks!
> 
> In tx/mcc polling, napi_complete() is being incorrectly called
> before reaping tx completions. This can cause tx compl processing
> to be scheduled on another cpu concurrently which can result in a panic.
> This if fixed by calling napi complete() after tx/mcc compl processing
> but before re-enabling interrupts (via a cq notify).
> 
> Signed-off-by: Sathya Perla <sathyap@...verengines.com>

Applied thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html