[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 3 Mar 2010 11:46:10 +0300
From: Dan Carpenter <error27@...il.com>
To: netdev@...r.kernel.org
Cc: Florian Fainelli <florian@...nwrt.org>,
"David S. Miller" <davem@...emloft.net>,
Ralf Baechle <ralf@...ux-mips.org>,
Jiri Pirko <jpirko@...hat.com>,
Stefan Weil <weil@...l.berlios.de>,
kernel-janitors@...r.kernel.org
Subject: [patch] cpmac: use after free
The original code dereferenced "cpmac_mii" after calling
"mdiobus_free(cpmac_mii);"
Signed-off-by: Dan Carpenter <error27@...il.com>
---
Found by a static checker and not tested. Sorry. :/
diff --git a/drivers/net/cpmac.c b/drivers/net/cpmac.c
index b85c81f..9d48942 100644
--- a/drivers/net/cpmac.c
+++ b/drivers/net/cpmac.c
@@ -1290,8 +1290,8 @@ void __devexit cpmac_exit(void)
{
platform_driver_unregister(&cpmac_driver);
mdiobus_unregister(cpmac_mii);
- mdiobus_free(cpmac_mii);
iounmap(cpmac_mii->priv);
+ mdiobus_free(cpmac_mii);
}
module_init(cpmac_init);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists