netdev - Re: [PATCH] Fix netdev_printk null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100305.070339.166010174.davem@davemloft.net>
Date:	Fri, 05 Mar 2010 07:03:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	steve.glendinning@...c.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix netdev_printk null dereference

From: Joe Perches <joe@...ches.com>
Date: Fri, 05 Mar 2010 06:50:20 -0800

> On Fri, 2010-03-05 at 06:39 -0800, David Miller wrote:
>> From: Steve Glendinning <steve.glendinning@...c.com>
>> Date: Fri,  5 Mar 2010 12:47:05 +0000
>> 
>> > This patch fixes a reproducible null dereference in smsc95xx (and I
>> > suspect others) when the device is removed during a control register
>> > access.  This can be reproduced by rapidly plugging and unplugging
>> > the device during its initialisation.
>> > 
>> > Signed-off-by: Steve Glendinning <steve.glendinning@...c.com>
>> 
>> The parent shouldn't become NULL until the device is totally quiesced
>> and is no longer accesses.
>> 
>> Maybe you can instead fix the smsc95xx driver to abide by this rule
>> instead of adding a conditional check to thousands of other drivers in
>> the tree that do not need this?
>> 
>> I really have no intention of adding your change, please fix this
>> properly, thanks.
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Perhaps something like this is appropriate in the mean time:
> 
> const char *get_netdev_parent_name(const struct net_device *dev)
> {
> 	if (!dev->dev.parent)
> 		return "Unparented net_device, please report this";
> 	return netdev->dev.parent;
> }

Yes,  but in the smsc95xx driver. :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html