lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 05 Mar 2010 08:42:40 -0800 (PST) From: David Miller <davem@...emloft.net> To: Steve.Glendinning@...c.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH] Fix netdev_printk null dereference From: Steve.Glendinning@...c.com Date: Fri, 5 Mar 2010 16:32:03 +0000 > David Miller <davem@...emloft.net> wrote on 05/03/2010 15:43:35: > >> Even more importantly, why does a USB disconnect NULL out the netdev >> parent device pointer? Until you actually release this USB device in >> the driver, the parent pointer should stay there. > > Most of the time it's not nulled out, and the code succesfully prints > errors as expected, but maybe 1 time in 20 dev.parent is NULL. I think until the device driver puts it's references and whatnot of the device it's driving, that parent pointer should be kept non-NULL. As long as the netdevice exists and is registered, for example, people can get at the parent device chain via SYSFS file accesses and similar. So it seems to me this is a huge problem waiting to happen anyways and this netdev_printk() issue is merely making the problem more obvious :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists