netdev - Re: [PATCH v4] ethtool: Add direct access to ops->get_sset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100305.140039.122978684.davem@davemloft.net>
Date:	Fri, 05 Mar 2010 14:00:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com
Subject: Re: [PATCH v4] ethtool: Add direct access to ops->get_sset_count

From: Jeff Garzik <jeff@...zik.org>
Date: Thu, 04 Mar 2010 08:23:05 -0500

> On 03/04/2010 03:51 AM, Jeff Kirsher wrote:
>> From: Jeff Garzik<jgarzik@...hat.com>
>>
>> This patch is an alternative approach for accessing string
>> counts, vs. the drvinfo indirect approach.  This way the drvinfo
>> space doesn't run out, and we don't break ABI later.
>>
>> Signed-off-by: Jeff Garzik<jgarzik@...hat.com>
>> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@...el.com>
>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@...el.com>
>> ---
>>
>>   include/linux/ethtool.h |   17 +++++++++--
>>   net/core/ethtool.c | 72
>>   +++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 86 insertions(+), 3 deletions(-)
> 
> Both patches look good to me.  There is a cosmetic issue of needing to
> sync up userspace and kernel ethtool.h WRT whitespace and deleted
> constants, but I can do that after DaveM applies this patch.
> 
> Waiting for upstream application, or other objections...

Applied, thanks guys.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html