netdev - Re: [patch] bridge: cleanup: remove unneed check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100306122031.GA15864@gondor.apana.org.au>
Date:	Sat, 6 Mar 2010 20:20:32 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Dan Carpenter <error27@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] bridge: cleanup: remove unneed check

On Sat, Mar 06, 2010 at 02:14:09PM +0300, Dan Carpenter wrote:
> We dereference "port" on the lines immediately before and immediately 
> after the test so port should hopefully never be null here.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Yes this looks correct to me.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html