netdev - Re: [patch] bluetooth: debugfs changes use too much stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1267897783.3712.0.camel@localhost.localdomain>
Date:	Sat, 06 Mar 2010 09:49:43 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Dan Carpenter <error27@...il.com>
Cc:	Jan Ceuleers <jan.ceuleers@...puter.org>,
	"David S. Miller" <davem@...emloft.net>,
	Dave Young <hidave.darkstar@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Roger Quadros <ext-roger.quadros@...ia.com>,
	Bing Zhao <bzhao@...vell.com>, linux-bluetooth@...r.kernel.org,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] bluetooth: debugfs changes use too much stack

Hi Dan,

> > Error handling?
> > 
> > > The original code would break with a 4K stack.
> > > 
> > > Signed-off-by: Dan Carpenter <error27@...il.com>
> > > ---
> > > This was compile tested only.  Sorry about that.
> > > 
> > > diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
> > > index 1a79a6c..835758f 100644
> > > --- a/net/bluetooth/hci_sysfs.c
> > > +++ b/net/bluetooth/hci_sysfs.c
> > > @@ -417,9 +417,11 @@ static ssize_t inquiry_cache_read(struct file *file, char __user *userbuf,
> > >  	struct hci_dev *hdev = file->private_data;
> > >  	struct inquiry_cache *cache = &hdev->inq_cache;
> > >  	struct inquiry_entry *e;
> > > -	char buf[4096];
> > > +	char *buf;
> > >  	int n = 0;
> > > +	ssize_t ret;
> > >  
> > > +	buf = kmalloc(4096, GFP_KERNEL);
> > 
> > Could this kmalloc not fail?
> 
> Grr...  I'm really sorry about that.
> 
> I will send an updated patch tomorrow.

please don't since we fixed this already in the net-2.6 tree.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html