lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100307014324.GA19589@gondor.apana.org.au> Date: Sun, 7 Mar 2010 09:43:24 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: John Fastabend <john.r.fastabend@...el.com> Cc: David Miller <davem@...emloft.net>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "gospo@...hat.com" <gospo@...hat.com> Subject: Re: [net-next-2.6 PATCH v2] net: consolidate netif_needs_gso() checks On Sat, Mar 06, 2010 at 11:27:50AM -0800, John Fastabend wrote: > > It looks like dev_gso_segment() could be used to "Verify header > integrity only" according to the comment? If this is true I think the > logic should probably be > > if (netif_needs_gso(dev, skb)) { > if (unlikely(dev_gso_segment(skb))) > goto out_kfree_skb; > if (skb->next) > goto gso; > } do your thing > > > > That way we linearize the skb if necessary in the case were > dev_gso_segment() only verifies the header and does not return a list of > segments. If we needed to linearise the skb then dev_gso_segment should perform the segmentation. Is there a case where it doesn't? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists