lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <201003071447.IAH35984.OJVFLOtQFFOSHM@I-love.SAKURA.ne.jp> Date: Sun, 7 Mar 2010 14:47:56 +0900 From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> To: sam@...ack.fr Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, hadi@...erus.ca, kaber@...sh.net, zbr@...emap.net, nhorman@...driver.com, root@...aldomain.pl, linux-security-module@...r.kernel.org, serue@...ibm.com Subject: Re: [RFC v2 00/10] snet: Security for NETwork syscalls Samir Bellabes wrote: > Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> writes: > > > Regarding [RFC v2 02/10] Revert "lsm: Remove the socket_post_accept() hook" > > @@ -1538,6 +1538,8 @@ SYSCALL_DEFINE4(accept4, int, fd, struct sockaddr __user *, upeer_sockaddr, > > fd_install(newfd, newfile); > > err = newfd; > > > > + security_socket_post_accept(sock, newsock); > > + > > out_put: > > fput_light(sock->file, fput_needed); > > out: > > > > Please move security_socket_post_accept() to before fd_install(). > > Otherwise, other threads which share fd tables can use > > security-informations-not-yet-updated accept()ed sockets. > > Tetsuo, what about this patch ? > Looks OK to me. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists