netdev - Re: [kernel,2.6.33-git11] lib8390: use spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100308.095637.175882761.davem@davemloft.net>
Date:	Mon, 08 Mar 2010 09:56:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ken_kawasaki@...ing.nifty.jp
Cc:	netdev@...r.kernel.org
Subject: Re: [kernel,2.6.33-git11] lib8390: use spin_lock_irqsave for
 locking

From: Ken Kawasaki <ken_kawasaki@...ing.nifty.jp>
Date: Mon, 8 Mar 2010 21:24:33 +0900

> 
>> This change is not correct.
>> 
>> disable_irq is being intentionally used because the reset
>> sequence can take a very long time and we don't want to
>> have cpu interrupts disabled during the entire sequence.
>> 
>> Otherwise slow serial devices will drop characters and
>> stuff like that.
> 
> 
> Actually, disable_irq is _not_ safe for lib8390 on SMP system.
> Same CPU or other CPU can call enable_irq.
> 
> so lib8390 does not work properly on my SMP system.

Then you need to fix that bug, because your patch here, again,
is not correct.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html