| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LSU.2.01.1003112205360.24500@obet.zrqbmnf.qr> Date: Thu, 11 Mar 2010 22:07:07 +0100 (CET) From: Jan Engelhardt <jengelh@...ozas.de> To: David Miller <davem@...emloft.net> cc: shemminger@...tta.com, netdev@...r.kernel.org Subject: Re: [PATCH 3/3] net: core: add IFLA_STATS64 support On Thursday 2010-03-11 21:26, David Miller wrote: >> On Thu, 11 Mar 2010 20:57:29 +0100 >> Jan Engelhardt <jengelh@...ozas.de> wrote: >> >>> `ip -s link` shows interface counters truncated to 32 bit. This is >>> because interface statistics are transported only in 32-bit quantity >>> to userspace. This commit adds a new IFLA_STATS64 attribute that >>> exports them in full 64 bit. >>> >>> References: http://lkml.indiana.edu/hypermail/linux/kernel/0307.3/0215.html >>> Signed-off-by: Jan Engelhardt <jengelh@...ozas.de> >>> >> >> What is the point since net_device_stats has only 32 bit counters. >> The last time this came up the issue was is that is not possible >> to atomically increment a 64 bit counter on most 32 bit platforms. > >On 64-bit it has 64-bit counters, yet we only report 32-bit >counters to userspace via netlink even in that case. > >That's what Jan is fixing here. On a side note, is it perhaps possible to use jiffies-like magic to also have 64-bit counters on 32-bit, or is that still too expensive? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists