netdev - RE: ixgbevf: bug in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Mar 2010 08:58:02 -0800
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	Dan Carpenter <error27@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: ixgbevf: bug in error handling

>-----Original Message-----
>From: Dan Carpenter [mailto:error27@...il.com]
>Sent: Thursday, March 11, 2010 2:33 AM
>To: Rose, Gregory V
>Cc: netdev@...r.kernel.org; kernel-janitors@...r.kernel.org
>Subject: ixgbevf: bug in error handling
>
>Hi Greg,
>
>drivers/net/ixgbevf/ixgbevf_main.c +3013 ixgbevf_tx_map(96) warn:
>unsigned 'i' is never less than zero.
>  3010          while (count >= 0) {
>  3011                  count--;
>  3012                  i--;
>  3013                  if (i < 0)
>  3014                          i += tx_ring->count;
>
>	There is a problem here because i is unsigned and just wraps
>	around instead of being less than 0.
>
>  3015                  tx_buffer_info = &tx_ring->tx_buffer_info[i];
>  3016                  ixgbevf_unmap_and_free_tx_resource(adapter,
>tx_buffer_info);
>  3017          }
>
>regards,
>dan carpenter

Ouch.  Good catch, we'll fix that right away.

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html