netdev - Re: [PATCH v7] rps: Receive Packet Steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65634d661003121505u6ad3d6adr50dc0ef8da7c726d@mail.gmail.com>
Date:	Fri, 12 Mar 2010 15:05:35 -0800
From:	Tom Herbert <therbert@...gle.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v7] rps: Receive Packet Steering

On Fri, Mar 12, 2010 at 2:23 PM, Stephen Hemminger
<shemminger@...tta.com> wrote:
> On Fri, 12 Mar 2010 12:13:12 -0800 (PST)
> Tom Herbert <therbert@...gle.com> wrote:
>
>> if (unlikely(index >= dev->num_rx_queues)) {
>> +                     if (net_ratelimit()) {
>> +                             WARN(1, "Received packet on %s for queue %u, "
>> +                                 "but number of RX queues is %u\n",
>> +                                  dev->name, index, dev->num_rx_queues);
>> +                     }
>> +                     goto done;
>
>
> Use dev_WARN? or invent netdev_WARN?
>

netdev_warn looks good.  I'll use that here and also in
dev_cap_txqueue where WARN is similarly used to be consistent.

Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html