netdev - Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Mar 2010 14:52:26 -0500
From:	Steven Harms <thisdyingdream@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	sjharms@...il.com, mcarlson@...adcom.com, mchan@...adcom.com,
	benli@...adcom.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, sharms@...ntu.com
Subject: Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding 
	style in tg3.c This is a patch to the tg3.c file that aligns switch and case 
	statements, else statements following braces, and inserts a space after 
	commas listed in the coding style g

David,

Would you like me to submit the patch adding only the spaces after
commas and leave the rest of the defines as is, or discard the changes
all together?

On Sat, Mar 13, 2010 at 2:49 PM, David Miller <davem@...emloft.net> wrote:
> From: Steven Harms <sjharms@...il.com>
> Date: Sat, 13 Mar 2010 14:39:11 -0500
>
>> -#define tw32_mailbox(reg, val)       tp->write32_mbox(tp, reg, val)
>> -#define tw32_mailbox_f(reg, val)     tw32_mailbox_flush(tp, (reg), (val))
>> -#define tw32_rx_mbox(reg, val)       tp->write32_rx_mbox(tp, reg, val)
>> -#define tw32_tx_mbox(reg, val)       tp->write32_tx_mbox(tp, reg, val)
>> -#define tr32_mailbox(reg)    tp->read32_mbox(tp, reg)
>> +#define tw32_mailbox(reg, val)       (tp->write32_mbox(tp, reg, val))
>
> Please keep this kind of code masterbation to yourself.
> This is not the style we want for this driver.
>



-- 
GPG Key ID: C92EF367 / 1428 FE8E 1E07 DDA8 EFD7 195F DCCD F5B3 C92E F367

WWW: http://www.sharms.org/blog
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html