netdev - Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1268511742.30289.74.camel@Joe-Laptop.home>
Date:	Sat, 13 Mar 2010 12:22:22 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	thisdyingdream@...il.com, sjharms@...il.com, mcarlson@...adcom.com,
	mchan@...adcom.com, benli@...adcom.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, sharms@...ntu.com
Subject: Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding
 style in tg3.c This is a patch to the tg3.c file that aligns switch and
 case statements, else statements following braces, and inserts a space
 after commas listed in the coding style g

On Sat, 2010-03-13 at 11:55 -0800, David Miller wrote:
> From: Steven Harms <thisdyingdream@...il.com>
> Date: Sat, 13 Mar 2010 14:52:26 -0500
> 
> > Would you like me to submit the patch adding only the spaces after
> > commas and leave the rest of the defines as is, or discard the changes
> > all together?
> 
> I would like you to toss them altogether.

I think that Steven got off on the wrong foot
a bit by adding the parentheses to the defines.

I think the other changes he suggested are
tree-wide style consistency only and are ok.

Perhaps you might reconsider later, after
net-next reopens.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html