netdev - [PATCH] ethtool.h: Add "structs are public" disclaimer comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1268583478.30289.94.camel@Joe-Laptop.home>
Date:	Sun, 14 Mar 2010 09:17:58 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	ajitk@...verengines.com, ajitkhaparde@...il.com, jeff@...zik.org,
	netdev@...r.kernel.org
Subject: [PATCH] ethtool.h: Add "structs are public" disclaimer comment

On Sat, 2010-03-13 at 18:11 -0800, David Miller wrote:
> For the millionth time, you cannot change these datastructures
> like this without breaking all existing userspace applications
> out there.

Maybe this might help reduce the broken record repetitiveness.

Signed-off-by: Joe Perches <joe@...ches.com>
---
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index b33f316..9bd7583 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -10,6 +10,15 @@
  * Portions Copyright (C) Sun Microsystems 2008
  */
 
+/*
+ * Do not submit patches that change the public structs not guarded by
+ * #ifdef __KERNEL__ in this file.
+ *
+ * In case the use of __u8, __u16, __u32 and other reserved types don't
+ * mean much to you, these structs are used by user-space applications
+ * and must not be changed.
+ */
+
 #ifndef _LINUX_ETHTOOL_H
 #define _LINUX_ETHTOOL_H
 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html