netdev - Re: [PATCH] ethtool.h: Add "structs are public" disclaimer comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 14 Mar 2010 15:08:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	ajitk@...verengines.com, ajitkhaparde@...il.com, jeff@...zik.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool.h: Add "structs are public" disclaimer comment

From: Joe Perches <joe@...ches.com>
Date: Sun, 14 Mar 2010 09:17:58 -0700

> On Sat, 2010-03-13 at 18:11 -0800, David Miller wrote:
>> For the millionth time, you cannot change these datastructures
>> like this without breaking all existing userspace applications
>> out there.
> 
> Maybe this might help reduce the broken record repetitiveness.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

That's rediculious.  Just about every single file in
include/linux/foo.h has similar stuff.

And we already have a way to document this, the fact that a header
file appears in include/linux/Kbuild shows that it provides userland
interfaces.

And your comment wouldn't help this person at all, they _KNEW_ it
changed userspace, because in the very next patch they patch the
userland tool to change the datastructures too!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html