netdev - Re: [PATCH 2/4] bnx2x: remove not necessary compiler barrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Mar 2010 15:47:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	sgruszka@...hat.com, netdev@...r.kernel.org, vladz@...adcom.com,
	mchan@...adcom.com
Subject: Re: [PATCH 2/4] bnx2x: remove not necessary compiler barrier

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Wed, 10 Mar 2010 18:00:57 +0200

> On Tue, 2010-03-09 at 08:55 -0800, Stanislaw Gruszka wrote:
>> Access to fp->tx_bd_prod is protected by __netif_tx_lock, so we do not
>> need any barrier for that.
>> 
>> Update of fp->tx_bd_cons in bnx2x_tx_int() is not protected by lock, but
>> barrier() nor smb_mb() in bnx2x_tx_avail() not guarantee we will see
>> values that is written on other cpu. Ordering issues between
>> netif_tx_stop_queue(), netif_tx_queue_stopped(), fp->tx_bd_cons = bd_cons
>> and bnx2x_tx_avail() are already handled by smp_mb() in bnx2x_tx_int()
>> and bnx2x_start_xmit().
>> 
>> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html