[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100315.203833.165440357.davem@davemloft.net>
Date: Mon, 15 Mar 2010 20:38:33 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: herbert@...dor.apana.org.au
Cc: michael-dev@...i-braun.de, netdev@...r.kernel.org
Subject: Re: [PATCH] BUG: unable to handle kernel NULL pointer dereference
at br_multicast_leave_group
From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 16 Mar 2010 11:10:05 +0800
> michael-dev@...i-braun.de wrote:
>>
>> I'm currently using linux-next and have been running into an OOPs which
>> I think might be caused by a patch you submitted on 2010-02-27.
>>
>> It's a linux-next kernel from 2010-03-12 on an x86 system and it
>> OOPs in the bridge module in br_mdp_ip_get (called by
>> br_multicast_leave_group) because the br->mdb is null.
>
> Thanks, there's actually another spot (the query handler) where
> the same thing can happen.
>
> Here's a patch to fix them both.
>
> bridge: Move NULL mdb check into br_mdb_ip_get
>
> Since all callers of br_mdb_ip_get need to check whether the
> hash table is NULL, this patch moves the check into the function.
>
> This fixes the two callers (query/leave handler) that didn't
> check it.
>
> Reported-by: Michael Braun <michael-dev@...i-braun.de>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
Applied, thanks Herbert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists