netdev - Re: [PATCH] route: Fix caught BUG_ON during rt_secret_rebuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100316181816.GC13529@hmsreliant.think-freely.org>
Date:	Tue, 16 Mar 2010 14:18:16 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Vitaliy Gusev <vgusev@...nvz.org>,
	"David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] route: Fix caught BUG_ON during
 rt_secret_rebuild_oneshot()

On Tue, Mar 16, 2010 at 07:08:42PM +0100, Eric Dumazet wrote:
> Le mardi 16 mars 2010 à 13:35 -0400, Neil Horman a écrit :
> > > 
> > Dave, Eric, Herbert, what are your opinions on this?  Is the statistical analysis code
> > mature enough at this point to warrant the removal of the rebuild timer, or
> > should we still keep it as a fallback mechanism?
> > Neil
> 
> I believe most heavy duty users dont use newest kernels yet.
> 
> (I had to make some changes last month because Paweł Staszewski had
> problems to get a working route cache)
> 
> We should wait a bit (one year or two) before removing this timer.
> 
> Thanks
> 
> 
> 
Ok, I just figured it was time to pose the question, since we'd fixed several
bugs in this area over the last year.  Certainly doesn't hurt to keep the
rebuild timer around a bit longer.  I re-iterate my ack to Vitaliy's patch then.

Regards
Neil


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html