netdev - Re: [PATCH net-2.6] bridge br_multicast: Don't refer to BR_INPUT_SKB_CB(skb)->mrouters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100316.143434.134315497.davem@davemloft.net>
Date:	Tue, 16 Mar 2010 14:34:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] bridge br_multicast: Don't refer to
 BR_INPUT_SKB_CB(skb)->mrouters_only without IGMP snooping.

From: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Date: Tue, 16 Mar 2010 16:51:18 +0900

> Without CONFIG_BRIDGE_IGMP_SNOOPING,
> BR_INPUT_SKB_CB(skb)->mrouters_only is not appropriately
> initialized, so we can see garbage.
> 
> A clear option to fix this is to set it even without that
> config, but we cannot optimize out the branch.
> 
> Let's introduce a macro that returns value of mrouters_only
> and let it return 0 without CONFIG_BRIDGE_IGMP_SNOOPING.
> 
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html