netdev - Re: e1000e: Fix build with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201003180051.23075.rjw@sisk.pl>
Date:	Thu, 18 Mar 2010 00:51:22 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:	David Miller <davem@...emloft.net>,
	"Tantilov, Emil S" <emil.s.tantilov@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: Re: e1000e: Fix build with CONFIG_PM disabled.

On Thursday 18 March 2010, Jesse Brandeburg wrote:
> On Wed, 2010-03-17 at 15:39 -0700, Rafael J. Wysocki wrote:
> > On Wednesday 17 March 2010, David Miller wrote:
> > > From: "Tantilov, Emil S" <emil.s.tantilov@...el.com>
> > > Date: Wed, 17 Mar 2010 11:57:59 -0600
> > > 
> > > > But then the driver build fails again when CONFIG_PM_RUNTIME is not set.
> > > > 
> > > > drivers/net/e1000e/netdev.c: In function `e1000_runtime_resume`:
> > > > drivers/net/e1000e/netdev.c:4807: error: `struct dev_pm_info` has no member named `runtime_auto`
> > > 
> > > Ugh, can someone send me a fix for that?
> > 
> > Appended, on top of your patch.  It only moves the code around and adds
> > #ifdefs.
> 
> I know this is throwing a wrench in things, but won't this series of
> changes break a clean bisect (due to the compile errors?)

Well, it will, but reverting them doesn't actually help fix bisectability.

You'd have to "git reset --hard" to the commit preceding them and then apply
the combo patch.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html